Fix: skip users having approved onboarding extension when applying groupOnboarding31d+ role #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajjs
force-pushed
the
fix/skip-onboarding-user
branch
2 times, most recently
from
9643feb to
ff70dbc
Compare
pankajjs
force-pushed
the
fix/skip-onboarding-user
branch
from
ff70dbc to
6040a74
Compare
AnujChhikara
reviewed
Jan 6, 2025
… extensions - Replaced sequential user processing with Promise.all to improve performance. - Enhanced error logging to include user IDs for better traceability. - Introduced a single timestamp variable to ensure consistent time comparisons.
|
LGTM |
AnujChhikara
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 2 Jan, 2025
Developer Name: @pankajjs
Issue Ticket Number
Description
groupOnboarding31d+role.Documentation Updated?
Under Feature Flag
/discord-actions/group-onboarding-31d-plusapi is invoked by cron job after every 30 minutes. I have not made the changes behind feature flag because there is not any user's control over feature flag to enable or disable it.Database Changes
Breaking Changes
Development Tested?
Screenshots
Working Videos
groupOnboarding31d+role.fix1.mp4
fix2.mp4
Test Coverage
Screenshots
Additional Notes